Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

fix(table): Allow table export to csv for keys with '.' #2808

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix(table): Allow table export to csv for keys with '.' #2808

merged 1 commit into from
Jan 29, 2024

Conversation

tomheller
Copy link
Collaborator

Pull Request

Hi, thank you for contributing to Barista with this pull request (PR).

To ensure a fast process and merging of your PR please make sure it fulfills the
coding standards and contribution guidelines.

  • A feature proposal has been provided, discussed and approved first.
  • There is a meaningful description of the issue in GitHub (Screenshots are
    often helpful).
  • If the PR introduces breaking-changes or deprecations it matches the following
    guidelines.
    • The commit message follows our commit guidelines.
    • Tests for the changes have been added (for bug fixes / features).
    • Docs have been added / updated (for bug fixes / features).

Please choose the type appropriate for the changes below:

Type of PR

Checklist

  • I have read the CONTRIBUTING doc and I follow the PR guidelines
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@tomheller tomheller requested a review from ffriedl89 as a code owner January 29, 2024 10:59
@github-actions GitHub Actions
Copy link

Deploy preview for barista ready!

✅ Preview
https://barista-o79t1u645-dynatrace-oss.vercel.app

Built with commit 3ef9bef.
This pull request is being automatically deployed with vercel-action

@tomheller tomheller added the pr: merge-ready This PR is ready to be merged label Jan 29, 2024
@github-actions github-actions bot added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release labels Jan 29, 2024
@tomheller tomheller merged commit b136e3e into master Jan 29, 2024
10 of 12 checks passed
@tomheller tomheller deleted the fix-table-nested-export branch January 29, 2024 12:53
@github-actions GitHub Actions
Copy link

The auto cherry picker succeeded.Cherry picked to minor branch 16.x. New head is now ad2508f
Cherry picked to patch branch 16.0.x. New head is now 924528a

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Sherif-Elhefnawy Sherif-Elhefnawy Sherif-Elhefnawy approved these changes

@LucasHocker LucasHocker Awaiting requested review from LucasHocker

@ffriedl89 ffriedl89 Awaiting requested review from ffriedl89 ffriedl89 is a code owner

Assignees
No one assigned
Labels
pr: merge-ready This PR is ready to be merged target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomheller @Sherif-Elhefnawy